[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 11/12] Fix leak in hotplug code in QEMU driver



On Wed, Jan 20, 2010 at 03:15:08PM +0000, Daniel P. Berrange wrote:
> The hotplug code in QEMU was leaking memory because although the
> inner device object was being moved into the main virDomainDefPtr
> config object, the outer container virDomainDeviceDefPtr was not.
> 
>  * src/qemu/qemu_driver.c: Clarify code to show that the inner
>    device object is owned by the main domain config upon
>    successfull attach.
> ---
>  src/qemu/qemu_driver.c |  190 ++++++++++++++++++++++++++----------------------
>  1 files changed, 103 insertions(+), 87 deletions(-)

  Okay, that results in a fairly large refactoring

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]