[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] FYI, [PATCH] avoid format-related warnings



Testing something unrelated, I saw these warnings:

  ../../src/conf/domain_conf.c: In function 'virDomainDeviceInfoParseXML':
  ../../src/conf/domain_conf.c:1120:9: warning: format not a string literal and no format arguments
  ../../src/conf/domain_conf.c:1138:9: warning: format not a string literal and no format arguments

Here's the patch I'll push shortly.
No ACK required.

>From 885f88c513d7d5004efca4899bfbced78536f371 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering redhat com>
Date: Thu, 21 Jan 2010 14:39:42 +0100
Subject: [PATCH] avoid format-related warnings

* src/conf/domain_conf.c (virDomainDeviceInfoParseXML): Use "%s".
---
 src/conf/domain_conf.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 27f6f84..74c2337 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1118,7 +1118,7 @@ virDomainDeviceInfoParseXML(virConnectPtr conn,
         }
     } else {
         virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR,
-                             _("No type specified for device address"));
+                             "%s", _("No type specified for device address"));
         goto cleanup;
     }

@@ -1136,7 +1136,7 @@ virDomainDeviceInfoParseXML(virConnectPtr conn,
     default:
         /* Should not happen */
         virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR,
-                             _("Unknown device address type"));
+                             "%s", _("Unknown device address type"));
         goto cleanup;
     }

--
1.6.6.513.g63f4c


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]