[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Fix setup of compatability serial devices from console device



On Fri, Jan 22, 2010 at 05:01:11PM +0000, Daniel P. Berrange wrote:
> The <console> tag is supposed to result in addition of a single
> <serial> device for HVM guests. The 'targetType' attribute was
> missing though causing the compatibility code to add a second
> <console> device
> 
> * src/conf/domain_conf.c: Set targetType for serial device
> ---
>  src/conf/domain_conf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 74c2337..e548d1d 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -3749,6 +3749,7 @@ static virDomainDefPtr virDomainDefParseXML(virConnectPtr conn,
>                  }
>                  def->nserials = 1;
>                  def->serials[0] = chr;
> +                chr->targetType = VIR_DOMAIN_CHR_TARGET_TYPE_SERIAL;
>              }
>          } else {
>              def->console = chr;

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]