[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] pci.c: correct erroneous expression



Chris Lalancette wrote:
> On 01/26/2010 02:41 PM, Jim Meyering wrote:
>> An expression like this, can never be true, since the RHS is nonzero:

For the record, it's "...since the RHS is > 1".

>>   ... !pciRead16(dev, PCI_CLASS_DEVICE) == PCI_CLASS_BRIDGE_PCI)
>>
>> This appears to be what was intended:
>>
>>   pciRead16(dev, PCI_CLASS_DEVICE) != PCI_CLASS_BRIDGE_PCI)
>
> Oops, yeah, that seems right.

Thanks.  Pushed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]