[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 REPOST 5/8] Qemu arbitrary monitor commands.



On 07/01/2010 02:59 PM, Chris Lalancette wrote:
> Implement the qemu driver's virDomainQemuMonitorCommand
> and hook it into the API entry point.
> 
> Changes since v1:
>  - Rename the (external) qemuMonitorCommand to qemuDomainMonitorCommand
>  - Add virCheckFlags to qemuDomainMonitorCommand
> 
> Signed-off-by: Chris Lalancette <clalance redhat com>
> +static int qemuDomainMonitorCommand(virDomainPtr domain, const char *cmd,
> +                                    char **result, unsigned int flags ATTRIBUTE_UNUSED)

Drop ATTRIBUTE_UNUSED...

> +{
> +    struct qemud_driver *driver = domain->conn->privateData;
> +    virDomainObjPtr vm = NULL;
> +    int ret = -1;
> +    qemuDomainObjPrivatePtr priv;
> +
> +    virCheckFlags(0, -1);

...since this uses it.

Other than that, ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]