[libvirt] [PATCH v2 REPOST 5/8] Qemu arbitrary monitor commands.

Eric Blake eblake at redhat.com
Fri Jul 2 03:31:30 UTC 2010


On 07/01/2010 02:59 PM, Chris Lalancette wrote:
> Implement the qemu driver's virDomainQemuMonitorCommand
> and hook it into the API entry point.
> 
> Changes since v1:
>  - Rename the (external) qemuMonitorCommand to qemuDomainMonitorCommand
>  - Add virCheckFlags to qemuDomainMonitorCommand
> 
> Signed-off-by: Chris Lalancette <clalance at redhat.com>
> +static int qemuDomainMonitorCommand(virDomainPtr domain, const char *cmd,
> +                                    char **result, unsigned int flags ATTRIBUTE_UNUSED)

Drop ATTRIBUTE_UNUSED...

> +{
> +    struct qemud_driver *driver = domain->conn->privateData;
> +    virDomainObjPtr vm = NULL;
> +    int ret = -1;
> +    qemuDomainObjPrivatePtr priv;
> +
> +    virCheckFlags(0, -1);

...since this uses it.

Other than that, ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100701/275ce1f6/attachment-0001.sig>


More information about the libvir-list mailing list