[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: virExec: Dispatch all errors raised after fork



On 06/30/2010 05:02 PM, Eric Blake wrote:
> On 06/30/2010 02:38 PM, Cole Robinson wrote:
>> Any error message raised after the process has forked needs
>> to be followed by virDispatchError, otherwise we have no chance of
>> ever seeing it. This was selectively done for hook functions in the past,
>> but really applies to all post-fork errors.
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
>> ---
>>  src/util/util.c |   26 ++++++++++++++------------
>>  1 files changed, 14 insertions(+), 12 deletions(-)
> 
> ACK, but let's fix a nit first...
> 
>>  
>> + fork_error:
>> +    virDispatchError(NULL);
>>      _exit(1);
> 
> ...while you're touching this, it's better to use _exit(EXIT_FAILURE)
> than _exit(1).
> 

Made that change and pushed.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]