[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 0/8]: Add arbitrary qemu command-line and monitor commands



On 07/02/2010 09:18 AM, Chris Lalancette wrote:
> As we discussed previously, here is the patch series to add the ability
> to specify arbitrary qemu command-line parameters and environment variables,
> and also give arbitrary monitor commands to a guest.  Because these
> extra arguments have a good shot at confusing libvirt, the use of them
> is not supported, but left available for advanced users and developers.
> They are also in a separate library and have a separate on-the-wire
> protocol.
> 
> I will point out one particular patch that could use some careful review,
> namely PATCH 6/8.  In there, I change the remote_message_hdr to use an
> unsigned proc instead of a remote_procedure proc.  Now, as far as I can tell
> the two sizes should be the same, so the wire protocol should be the same.
> Indeed, testing seems to show that older virsh can talk just fine to a libvirtd
> with this patch applied.  However, the regenerated remote_protocol.c file for
> parsing remote_message_header has some strange bits in it that I don't quite
> understand.  I'm hoping someone else can look at it and confirm that it is OK.

I think the generated files are fine; to me, it looks like the
difference was due to calling a helper function for
remote_message_header vs. inlining direct handling of a native unsigned
type.

> 
> Thanks to Dan Berrange and Eric Blake for their reviews already, and to DV
> for the Relax NG schema changes.
> 
> Changes since v2 are listed in the individual patches.

ACK series, modulo one nit to patch 2 - I reviewed all the changes in v3
and the remaining patches looked fine as is.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-- 
Eric Blake
volunteer cygwin package maintainer

CYGWIN-ANNOUNCE UNSUBSCRIBE INFO:
=================================
To unsubscribe to the cygwin-announce mailing list, look at the
"List-Unsubscribe: " tag in the email header of this message.  Send email
to the address specified there.  It will be in the format:

cygwin-announce-unsubscribe-YOU=YOURDOMAIN COM cygwin com

If you need more information on unsubscribing, start reading here:

http://sourceware.org/lists.html#unsubscribe-simple

Please read *all* of the information on unsubscribing that is available
starting at this URL.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]