[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 1/2] virsh: add new --details option to pool-list



On Sat, Jul 03, 2010 at 07:03:14PM +1000, Justin Clift wrote:
> On 07/01/2010 08:38 PM, Richard W.M. Jones wrote:
> <snip>
> >>virsh # pool-list --details --all
> >>Name       State     Autostart  Persistent  Capacity  Allocation  
> >>Available
> >>---------------------------------------------------------------------------
> >>default    running   yes        yes          1.79 TB     1.49 TB  304.77 
> >>GB
> >>image_dir  running   yes        yes          1.79 TB     1.49 TB  304.77 
> >>GB
> >>tmp        inactive  no         yes                -           -          
> >>-
> <snip>
> >* Space within fields "1.79 TB" (awk / sort -k in fact _won't_ work).
> 
> Tried it without the embedded spacing today (and submitted patches),
> but really not a fan of the output:
> 
> ***************************************************************************
> 
> virsh # pool-list --all --details
> Name       State     Autostart  Persistent  Capacity  Allocation Available
> ---------------------------------------------------------------------------
> default    running   yes        yes          19.69GB     15.97GB   3.71GB
> image_dir  running   yes        yes           1.79TB      1.59TB 203.69GB
> tmp        inactive  no         yes                -           -        -
> 
> ***************************************************************************
> 
> Would it be workable to retain the space between the columns, instead
> changing the "-" value in the "pool-list --details" example like this:
> 
> ***************************************************************************
> 
> virsh # pool-list --all --details
> Name       State     Autostart  Persistent  Capacity  Allocation Available
> ---------------------------------------------------------------------------
> default    running   yes        yes         19.69 GB    15.97 GB   3.71 GB
> image_dir  running   yes        yes          1.79 TB     1.59 TB 203.69 GB
> tmp        inactive  no         yes            -- --       -- --     -- --
> 
> ***************************************************************************
> 
> Thinking this would keep the number of columns consistent, but also be
> readable for people.

IMHO your original formatting is the best. Both of these new alternatives
looks worse.  We should be picking the more human friendly option here and
not worry about machine readability for this

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]