[libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

[Ryota Ozaki]

On Mon, Jul 5, 2010 at 10:11 PM, Ryota Ozaki <ozaki.ryota at gmail.com> wrote:
> On Mon, Jul 5, 2010 at 9:46 PM, Daniel Veillard <veillard at redhat.com> wrote:
>> On Mon, Jul 05, 2010 at 07:40:50PM +0900, Ryota Ozaki wrote:
>>> On Mon, Jul 5, 2010 at 6:52 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
>>> > On Sun, Jul 04, 2010 at 07:02:32AM +0900, Ryota Ozaki wrote:
>>> >> [error message]
>>> >>   CC     libvirtd-dispatch.o
>>> >> dispatch.c: In function 'remoteDispatchFormatError':
>>> >> dispatch.c:83: error: 'va_list' undeclared (first use in this function)
>>> >> dispatch.c:83: error: (Each undeclared identifier is reported only once
>>> >> dispatch.c:83: error: for each function it appears in.)
>>> >> dispatch.c:83: error: expected ';' before 'args'
>>> >> cc1: warnings being treated as errors
>>> >> dispatch.c:87: error: implicit declaration of function 'va_start' [-Wimplicit-function-declaration]
>>> >> dispatch.c:87: error: nested extern declaration of 'va_start' [-Wnested-externs]
>>> >> dispatch.c:87: error: 'args' undeclared (first use in this function)
>>> >> dispatch.c:88: error: implicit declaration of function 'vsnprintf' [-Wimplicit-function-declaration]
>>> >> dispatch.c:89: error: implicit declaration of function 'va_end' [-Wimplicit-function-declaration]
>>> >> dispatch.c:89: error: nested extern declaration of 'va_end' [-Wnested-externs]
>>> >
>>> > What build platform do you see these errors on ?
>>>
>>> Fedora 12.
>>>
>>> I've confirmed with a clean slate, but the errors still happen.
>>> What I've done is:
>>> ./autogen.sh --enable-compile-warnings=error --enable-debug
>>> nice make -sj2
>>>
>>> The errors still happen when --enable-debug dropped.
>>
>>  Weird, I'm F12 too, git pulled and followed exactly the same steps and
>> no problem here:
>>
>> Making all in daemon
>>  GEN    libvirtd.lxc.logrotate
>>  GEN    libvirtd.uml.logrotate
>>  GEN    libvirtd.init
>>  GEN    libvirt-guests.init
>>  CC     libvirtd-event.o
>>  CC     libvirtd-libvirtd.o
>>  CC     libvirtd-remote.o
>>  CC     libvirtd-dispatch.o
>>  CC     libvirtd-stream.o
>>
>> paphio:~/libvirt -> uname -a
>> Linux paphio.veillard.com 2.6.32.14-127.fc12.x86_64 #1 SMP Fri May 28
>> 04:30:39 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux
>>
>>  it's an F12 fully updated.
>
> Oh, my box holds many pending packages to be updated.
>
> I'm now installing them all. I'll report the result of testing on
> the environment laster.

Unfortunately the errors still happen after updating. Even worse, they happen
on an old commit that I was able to compile successfully so far. So I guess
my box went wrong at some point.

Please ignore the patch because it seems a problem of my box...

Thanks.
  ozaki-r

>
> Thanks.
>  ozaki-r
>
>>
>> Daniel
>>
>> --
>> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
>> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
>> http://veillard.com/ | virtualization library  http://libvirt.org/
>>
>