[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/8] Qemu arbitrary command-line arguments.



On Fri, Jul 02, 2010 at 11:18:19AM -0400, Chris Lalancette wrote:
> Implement the qemu hooks for XML namespace data.  This
> allows us to specify a qemu XML namespace, and then
> specify:
> 
> <qemu:commandline>
>  <qemu:arg value='arg'/>
>  <qemu:env name='name' value='value'/>
> </qemu:commandline>
> 
> In the domain XML.
> 
> Changes since v1:
>  - Change the <qemu:arg>arg</qemu:arg> XML to <qemu:arg value='arg'/> XML
>  - Fix up some memory leaks in qemuDomainDefNamespaceParse
>  - Rename num_extra and extra to num_args and args, respectively
>  - Fixed up some error messages
>  - Make sure to escape user-provided data in qemuDomainDefNamespaceFormatXML
> 
> Changes since v2:
>  - Add checking to ensure environment variable names are valid
>  - Invert the logic in qemuDomainDefNamespaceFormatXML to return early
> 
> Signed-off-by: Chris Lalancette <clalance redhat com>
> 
> arbitrary command-line arguments
> ---
>  src/qemu/qemu_conf.c   |   14 ++++
>  src/qemu/qemu_conf.h   |   11 +++
>  src/qemu/qemu_driver.c |  171 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 196 insertions(+), 0 deletions(-)

ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]