[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Ensure we return the callback ID in python events binding



> A missing return statement in the python binding meant that
> the callers could not get the callback ID, and thus not be
> able to unregister event callbacks
> 
> * python/libvirt-override-virConnect.py: Add missing return
>   statement
> ---
>  python/libvirt-override-virConnect.py |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/python/libvirt-override-virConnect.py b/python/libvirt-override-virConnect.py
> index 1a1cdd0..52914dc 100644
> --- a/python/libvirt-override-virConnect.py
> +++ b/python/libvirt-override-virConnect.py
> @@ -146,3 +146,4 @@
>          if ret == -1:
>              raise libvirtError ('virConnectDomainEventRegisterAny() failed', conn=self)
>          self.domainEventCallbackID[ret] = opaque
> +        return ret

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]