[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] RFC: Canonicalize block device paths



On Thu, Jul 08, 2010 at 07:37:03PM -0400, David Allan wrote:
> There are many naming conventions for partitions associated with a
> block device.  Some of the major ones are:
> 
> /dev/foo -> /dev/foo1
> /dev/foo1 -> /dev/foo1p1
> /dev/mapper/foo -> /dev/mapper/foop1
> /dev/disk/by-path/foo -> /dev/disk/by-path/foo-part1
> 
> The universe of possible conventions isn't clear.  Rather than trying
> to understand all possible conventions, this patch divides devices
> into two groups, device mapper devices and everything else.  Device
> mapper devices seem always to follow the convention of device ->
> devicep1; everything else is canonicalized.

  This starts to be a bit messy, I have no objection to the code but
it would be good to start entering this in the test suite one way or
another, so that is we need to change it again, we make sure to not
break any of the expected behaviour for previous cases.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]