[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuConnectMonitor: do not mask SELinux failure



Matthias Bolte wrote:
> 2010/7/13 Jim Meyering <jim meyering net>:
>> coverity spotted the expressions that could never be true:
>> (a && b && c) < 0.  Here's the fix:
>>
>>
>> >From 6d61d90a6df81900f4b2be752403758175000973 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <meyering redhat com>
>> Date: Tue, 13 Jul 2010 15:15:04 -0500
>> Subject: [PATCH] qemuConnectMonitor: fix a bug that would have masked SELinux failure
>>
>> * src/qemu/qemu_driver.c (qemuConnectMonitor): Correct erroneous
>> parenthesization in two expressions.  Without this fix, failure
>> to set or clear SELinux security context in the monitor would go
>> undiagnosed.  Also correct a diagnostic and split some long lines.
>> ---
>
> ACK.

Hi Matthias,
Thanks for the review.  I've pushed that.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]