[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/11] Require format to be passed into virStorageFileGetMetadata



On Mon, Jul 12, 2010 at 02:30:41PM +0100, Daniel P. Berrange wrote:
> Require the disk image to be passed into virStorageFileGetMetadata.
> If this is set to VIR_STORAGE_FILE_AUTO, then the format will be
> resolved using probing. This makes it easier to control when
> probing will be used
> 
> * src/qemu/qemu_driver.c, src/qemu/qemu_security_dac.c,
>   src/security/security_selinux.c, src/security/virt-aa-helper.c:
>   Set VIR_STORAGE_FILE_AUTO when calling virStorageFileGetMetadata.
> * src/storage/storage_backend_fs.c: Probe for disk format before
>   calling virStorageFileGetMetadata.
> * src/util/storage_file.h, src/util/storage_file.c: Remove format
>   from virStorageFileMeta struct & require it to be passed into
>   method.

  Okay sort of work around for my question on previous patch for most
  cases,

   ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]