[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] cpu: Add support for CPU vendor



On Fri, Jul 02, 2010 at 11:16:22PM +0200, Jiri Denemark wrote:
> By specifying <vendor> element in CPU requirements a guest can be
> restricted to run only on CPUs by a given vendor. Host CPU vendor is
> also specified in capabilities XML.
> 
> The vendor is checked when migrating a guest but it's not forced, i.e.,
> a guest configured without <vendor> element can be freely migrated.
> ---
> 
> Sorry for such a big patch but the bulk of it is in cpu/ which is not so easy
> to be splitted reasonably.
> 
> 
>  docs/formatcaps.html.in     |    1 +
>  docs/formatdomain.html.in   |    8 +
>  docs/schemas/capability.rng |    5 +
>  docs/schemas/domain.rng     |    7 +
>  src/conf/cpu_conf.c         |   14 ++
>  src/conf/cpu_conf.h         |    1 +
>  src/cpu/cpu.c               |    9 +-
>  src/cpu/cpu.h               |    6 +-
>  src/cpu/cpu_map.c           |   36 ++++--
>  src/cpu/cpu_map.h           |   20 ++-
>  src/cpu/cpu_map.xml         |    6 +

Why did you add <vendor> tags to several of the models there? Does qemu
(-no-kvm) have any problem emulating athlon on an Intel host?

And how about adding policy='disable' attribute, so that I can ask
virConnectCompareCPU to ignore this particular incompatibility, as I do
with <feature> items?

Regards,
Dan.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]