[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] pciSharesBusWithActive fails to find multiple devices on bus



On 07/22/2010 05:01 PM, Chris Wright wrote:
> The first conditional is always true which means the iterator will
> never find another device on the same bus.
> 
>     if (dev->domain != check->domain ||
>         dev->bus != check->bus ||
>   ----> (check->slot == check->slot &&
>          check->function == check->function)) <-----

Ouch.  ACK to the patch.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]