[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 4/8] Qemu Monitor API entry point.



On 07/23/2010 09:42 AM, Chris Lalancette wrote:
On 07/20/10 - 11:56:52AM, Daniel P. Berrange wrote:
This needs to be a in a separate libvirt_qemu_public.syms since
this symbol is in a separate library. Also make sure to give
it a different version name, eg  LIBVIRT_QEMU_0.8.3

Here's a "diff-diff", which shows the changes I've done to address this
concern.  Assuming you are OK with this, I'll push this series (minus the
virsh patch) today.

The tool interdiff (from the patchutils package) makes it a little easier to visualize what you changed between the state of two diffs.

At any rate, ACK on those changes, from my point of view.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]