[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] virt-aa-helper: Ignore open errors again



On Fri, 2010-07-23 at 19:24 +0200, Matthias Bolte wrote:
> virt-aa-helper used to ignore errors when opening files.
> Commit a8853344994a7c6aaca882a5e949ab5536821ab5 refactored
> the related code and changed this behavior. virt-aa-helper
> didn't ignore open errors anymore and virt-aa-helper-test
> fails.
> 
> Make sure that virt-aa-helper ignores open errors again.
> ---
>  src/security/virt-aa-helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c
> index 521545d..16b1920 100644
> --- a/src/security/virt-aa-helper.c
> +++ b/src/security/virt-aa-helper.c
> @@ -846,7 +846,7 @@ get_files(vahControl * ctl)
>      for (i = 0; i < ctl->def->ndisks; i++) {
>          int ret = virDomainDiskDefForeachPath(ctl->def->disks[i],
>                                                ctl->allowDiskFormatProbing,
> -                                              false,
> +                                              true,
>                                                add_file_path,
>                                                &buf);
>          if (ret != 0)

I'm not 100% sure on this one. I have been developing patches to adjust
for the new behavior on older releases and I did some shuffling to get
this to work with 'false'. I'm not ready to submit at this time, and
won't be able to get to it until the week after next. If this blocks
Matthias' work, then feel free to commit and I'll post with a different
patch if needed. Otherwise, we can wait.

-- 
Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]