[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] qemu: virtio console support



On Mon, Jul 26, 2010 at 03:16:25PM -0400, Cole Robinson wrote:
> Enable specifying a virtio console device with:
> 
> <console type='pty'>
>   <target type='virtio'/>
> </console>
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>

ACK, but one extra thing you need here I think. When I tested
it I had to manually add a <controller> element. We should be
auto-adding a <controller> for virtio serial if we get a 
virtio <console> device, in same way we do for virtio <channel>
devices.


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]