[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] qemu: virtio console support



On 07/28/2010 06:22 AM, Daniel P. Berrange wrote:
> On Mon, Jul 26, 2010 at 03:16:25PM -0400, Cole Robinson wrote:
>> Enable specifying a virtio console device with:
>>
>> <console type='pty'>
>>   <target type='virtio'/>
>> </console>
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
> 
> ACK, but one extra thing you need here I think. When I tested
> it I had to manually add a <controller> element. We should be
> auto-adding a <controller> for virtio serial if we get a 
> virtio <console> device, in same way we do for virtio <channel>
> devices.
> 

Hmm, I can't reproduce: there is even an explicit unit test case for
this, so not sure what steps you took to trigger the issue.

I've pushed this series now, let me know if you can still reproduce.

Thanks,
Cole




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]