[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a memory leak in the qemudBuildCommandLine.



On 07/30/2010 07:47 AM, Chris Lalancette wrote:
> ADD_ARG_LIT should only be used for literal arguments,
> since it duplicates the memory.  Since virBufferContentAndReset
> is already allocating memory, we should only use ADD_ARG.

ACK.

Hmm, wondering if there is a way to make use of gcc's
__builtin_constant_p() to enforce that ADD_ARG_LIT is passed a string
constant.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]