[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] openvzDomainCreateWithFlags: set domain id to the correct value



2010/7/30 Matthias Bolte <matthias bolte googlemail com>:
> 2010/7/30 Jean-Baptiste Rouault <jean-baptiste rouault diateam net>:
>> I'm not sure if it's ok or not to modify dom->id as I did here.
>>
>> Regards,
>> Jean-Baptiste
>>
>
> I think this is a bug that needs to be fixed and the patch is correct.
> After starting a domain it has to have a valid ID >= 0.
>
> I'm currently checking the other drivers, and the ESX and XenAPI
> drivers are affected too.
>
> The QEMU driver is also affected, but because it's always tunneled
> through the remote driver and the remote driver isn't affected, this
> problem doesn't surface for the QEMU driver. The same is true for the
> LXC, UML and ONE drivers.
>
> Matthias
>

ACK to your patch, I applied and pushed it.

This ID update problem exists in several other drivers too and I
posted patches to fix them.

Thanks for reporting and fixing this one, with the side effect of
revealing this as a general problem.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]