[libvirt] [PATCHv4 1/2] virsh: add new --details option to pool-list
Daniel P. Berrange
berrange at redhat.com
Tue Jun 22 17:54:55 UTC 2010
On Tue, Jun 22, 2010 at 11:44:57AM -0600, Eric Blake wrote:
> On 06/21/2010 03:47 PM, Justin Clift wrote:
> > This patch adds a new --details option to the virsh pool-list
> > command, making its output more useful to people who use virsh
> > for significant lengths of time.
> >
> > Addresses BZ # 605543
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=605543
> >
> > + /* Determine the total number of pools to list */
> > + numAllPools = numActivePools + numInactivePools;
> > + if (!numAllPools) {
> > + /* No pools to list, so cleanup and return */
> > + vshPrint(ctl, "%s\n", _("No matching pools to display"));
> > + return TRUE;
> > + }
>
> This is a change in behavior, even when the user didn't specify
> --details. Might it cause any backward compatibility issues in
> scripting, or are we okay with the change?
Correct, we shouldn't change this behaviour - it'll break apps parsing
the output
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list