[libvirt] [PATCH 2/2] Add --source-format argument to virsh pool-define-as and pool-create-as

Justin Clift justin at salasaga.org
Wed Jun 2 03:01:44 UTC 2010


On 06/02/2010 08:59 AM, Eric Blake wrote:
> On 06/01/2010 09:50 AM, Cole Robinson wrote:
>> On 05/30/2010 10:24 AM, Justin Clift wrote:
>
>>> Also created a Red Hat BZ ticket for this (#597790) for tracking.
>
>>> This is the corresponding patch for the virsh man page (virsh.pod).
>>>
>>
>> ACK
>
> Second that.  And *kudos* to you for updating the documentation along
> with the implementation, as well as creating the corresponding BZ!  If
> only all first-time contributor bug reports were this nice!  Pushed both
> patches.  My only suggestion for the future is to use 'git format-patch'
> or 'git send-email', so that your commit message is preserved intact,
> rather than just attaching the 'git diff' output, so that I don't have
> to trim your entire email body down into a commit message.

Interesting, thanks.  New to git, and learning as I go. :)

Regards and best wishes,

Justin Clift

-- 
Salasaga  -  Open Source eLearning IDE
               http://www.salasaga.org




More information about the libvir-list mailing list