[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Add mkfs and libblkid to build system v2



On 06/02/2010 01:09 PM, David Allan wrote:
> Change per feedback from Dan B:

The configure.ac portion still has my ack.  However,

> * Add libblkid dependency to libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -228,6 +228,11 @@ BuildRequires: util-linux
>  # For showmount in FS driver (netfs discovery)
>  BuildRequires: nfs-utils
>  Requires: nfs-utils
> +# For mkfs
> +Requires: util-linux
> +# For pool-build probing for existing pools
> +BuildRequires: libblkid-devel >= 2.17
> +Requires: libblkid >= 2.17

My .spec-fu is not the best yet, but isn't it sufficient to just list
BuildRequires?  My understanding is that rpmbuild will automatically add
Requires to the corresponding library package when it detects that the
.so was in use, without you having to list both lines.  For a
comparison, note how we only list BuildRequires: libpciaccess-devel >=
0.10.9 rather than also listing Requires: libpciaccess.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]