[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v13] [REPOST] add 802.1Qbh and 802.1Qbg handling



On Mon, 2010-05-31 at 18:14 +0200, Jim Meyering wrote:

> 
> Hi Stefan,
> 
> Sorry, but my suggestion was incomplete.  *endptr == '\0' indicates
> a valid conversion, too.  That's what would happen if there's no byte
> at all (not even a trailing newline) after the PID.  In addition, when
> virStrToLong_ui returns 0, endptr cannot be NULL, so there was no need
> for that test.  This handles it:
> 
>                 && (*endptr == '\0' || c_isspace(*endptr))
> 
> With that, ACK.
> 

Fixed it, ran a couple of tests and pushed. Thanks.

Regards,
   Stefan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]