[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Fix device destroy return value



On 06/02/2010 08:09 PM, David Allan wrote:
> ---
>  src/conf/node_device_conf.c          |    4 ++--
>  src/node_device/node_device_driver.c |    3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
>  static int
>  nodeDeviceDestroy(virNodeDevicePtr dev)
>  {
> -    int ret = 0;
> +    int ret = -1;
>      virDeviceMonitorStatePtr driver = dev->conn->devMonPrivateData;
>      virNodeDeviceObjPtr obj = NULL;
>      char *parent_name = NULL, *wwnn = NULL, *wwpn = NULL;
> @@ -631,6 +631,7 @@ nodeDeviceDestroy(virNodeDevicePtr dev)
>          goto out;
>      }
> 
> +    ret = 0;
>  out:

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]