[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Update nodedev scsi_host data before use



On 06/02/2010 10:04 PM, David Allan wrote:
> * It appears that the udev event for HBA creation arrives before the
>   associated sysfs data is fully populated, resulting in bogus data
>   for the nodedev entry until the entry is refreshed.  This problem is
>   particularly troublesome when creating NPIV vHBAs because it results
>   in libvirt failing to find the newly created adapter and waiting for
>   the full timeout period before erroneously failing the create
>   operation.  This patch forces an update before any attempt to use
>   any scsi_host nodedev entry.
> ---
>  src/node_device/node_device_driver.c |   19 +++----------------
>  1 files changed, 3 insertions(+), 16 deletions(-)

ACK.  It's always nice when a net reduction in lines solves a race
condition.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]