[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] autobuild.sh: avoid bashism



On 06/04/2010 09:49 AM, Matthias Bolte wrote:
>>
>> -set -o pipefail
>> -make check 2>&1 | tee "$RESULTS"
>> -make syntax-check 2>&1 | tee -a "$RESULTS"
>> +# set -o pipefail is a bashism; this use of exec is the POSIX alternative
>> +exec 3>&1
>> +st=$(
>> +  exec 4>&1 >&3
>> +  { make check syntax-check 2>&1; echo $? >&4; } \
>> +  | tee "$RESULTS"
>> +)

Technically, to be identical to the earlier version, I would have to use:

st=$(
  exec 4>&1 >&3 3>&-
  { make check syntax-check 2>&1 4>&-; echo $? >&4; } \
  | tee "$RESULTS" 4>&-
)

but leaking fd 3 and 4 to make and tee didn't bother me.

> 
> ACK, tested and verified that it fixes the problem.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]