[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Added snapshot backing store parameters to virsh.



On 06/05/2010 10:13 PM, Justin Clift wrote:
<snip>
+ virStorageVolPtr snapVol = virStorageVolLookupByName(pool,
snapshotStrVol);
+ if (snapVol == NULL) {
+ return FALSE;
+ }
<snip>

Thought about it more, and this could do with better failure handling here. I'll resubmit this patch so it tests the given volume string as a key or a path if not found as a name, plus alert the user if the backing store volume wasn't found.

Regards and best wishes,

Justin Clift

--
Salasaga  -  Open Source eLearning IDE
              http://www.salasaga.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]