[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix minor virsh man page typos and formatting problems.



On Tue, Jun 08, 2010 at 04:36:05PM +1000, Justin Clift wrote:
> On 06/08/2010 10:23 AM, Eric Blake wrote:
> >On 06/05/2010 04:39 AM, Justin Clift wrote:
> >>---
> >>  tools/virsh.pod |   12 ++++++------
> >>  1 files changed, 6 insertions(+), 6 deletions(-)
> >>
> >>diff --git a/tools/virsh.pod b/tools/virsh.pod
> >>index 422ae7f..79900e5 100644
> >>--- a/tools/virsh.pod
> >>+++ b/tools/virsh.pod
> >>@@ -89,7 +89,7 @@ Running hypervisor: Xen 3.0.0
> >>   =back
> >>  -=item B<cd>  I<directory>  optional
> >>+=item B<cd>  optional I<directory>
> >
> >Thanks for catching these!
> >
> >This patch came across as corrupted for me; notice the space inserted
> >before the leading -, and the missing blank lines.  Possibly due to a
> >botched mime type from your mailer?
> 
> Ouch, no worries.  Looks like either my process is bad, or Thunderbird 
> isn't handing things so well. :(
> 
> >I went ahead and manually applied the intended changes, but don't want
> >to make a habit of spending that much time on broken patches.
> 
> Understood.  I'll look into other mailers.

For just sending patches to the list, the simplest way is to just use GIT
itself. eg, my workflow is to create a branch for all my changes, and
then periodically spam the list with the changes on the branch

   git checkout -b mywork
   ...make some commits on 'mywork' branch
   git send-email \
          --compose \
          --no-chain-reply-to \
          --to libvir-list redhat com master..

Since we're on 'mybranch', the tag 'master..'  means send all the
commits made on the branch that aren't in master. The '--compose'
is good if you're sending a series of patches, making it display 
an editor for writing the covering letter. The commit messages
form the body of each mail.

Tip when learning to use git send-email is to send the email to
yourself instead of the mailing list first :-)

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]