[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh.

On 06/08/2010 11:17 PM, Eric Blake wrote:
On 06/08/2010 06:03 AM, Justin Clift wrote:
Hi all,

Much better - git am liked this patch.  And a tip for your matching your
commit message style to other commits: list a category first, use all
lower-case, and end without a period.  While not essential, doing these
things will make 'git log --oneline' produce more readable output.

Thanks. :)

No change to tools/virsh.pod?  I know you have other cleanup patches to
virsh.pod, but for a new feature, I'd rather get in the habit of
checking in the doc change at the same time as the new feature.

I need to resubmit a large virsh.pod patch, because at present there are no Volume commands in there at all, giving nowhere to add this.

I'll add this vol-pool command to that. :)

The rest of this file used /* */ comments.  It's nice to be consistent
(even though we require C99 for various other reasons, we're still stuck
on some C89 syntax constructs for style reasons).

Cool, will fix.

In general, this looks okay to me, but I'll wait for the next round
addressing the nits I raised before pushing anything.

No worries. :)

Regards and best wishes,

Justin Clift

Salasaga  -  Open Source eLearning IDE

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]