[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump



On Tue, Jun 08, 2010 at 09:40:30AM +0100, Daniel P. Berrange wrote:
> On Mon, Jun 07, 2010 at 04:58:08PM -0400, David Allan wrote:
> > ---
> >  src/conf/storage_conf.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
> > index 422e76a..7ed49a1 100644
> > --- a/src/conf/storage_conf.c
> > +++ b/src/conf/storage_conf.c
> > @@ -815,6 +815,13 @@ virStoragePoolSourceFormat(virBufferPtr buf,
> >          src->name)
> >          virBufferVSprintf(buf,"    <name>%s</name>\n", src->name);
> > 
> > +    if ((options->flags & VIR_STORAGE_POOL_SOURCE_INITIATOR_IQN) &&
> > +        src->initiator.iqn) {
> > +        virBufferAddLit(buf,"    <initiator>\n");
> > +        virBufferVSprintf(buf,"      <iqn name='%s'/>\n", src->initiator.iqn);
> 
> For paranoia, we should probably use virBufferEscapeString() in this place

Made that change and pushed.  Thanks.

Dave


> > +        virBufferAddLit(buf,"    </initiator>\n");
> > +    }
> > +
> 
> Regards,
> Daniel
> -- 
> |: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
> |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
> |: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
> |: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]