[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] Fix leaks in udev device add/remove v3



On 06/07/2010 11:23 AM, David Allan wrote:
> * This patch is a modification of a patch submitted by Nigel Jones.
>   It fixes several memory leaks on device addition/removal:
> 
> 1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return
>    value is non-zero
> 
> 2. Always release the node device reference after the device has been
>    processed.
> 
> * Refactored for better readability per the suggestion of clalance

Yes, in comparing the two versions, I can see the improvement.  ACK on
this version.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]