[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] virDomainCreateXML: support new flag



> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 19d5205..c806441 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -121,7 +121,8 @@ typedef virDomainInfo *virDomainInfoPtr;
>   * Domain.
>   */
>  typedef enum {
> -     VIR_DOMAIN_NONE = 0
> +    VIR_DOMAIN_NONE         = 0,      /* Default behavior */
> +    VIR_DOMAIN_START_PAUSED = 0 << 1, /* Launch guest in paused state */
>  } virDomainCreateFlags;

I believe, you wanted to write 1 << 0 as a value of VIR_DOMAIN_START_PAUSED,
didn't you?

The rest of this patch looks just fine to me, ACK.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]