[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] qemu: allow creation of a paused domain



> https://bugzilla.redhat.com/show_bug.cgi?id=589465
> 
> Some guests (eg with badly configured grub, or Windows' installation cd)
> require quick response from the console user. That's why we have a
> "launchPaused" option in vdsm.
> 
> To implement it via libvirt, we need to ask libvirt not to call
> qemuMonitorStartCPUs() after starting qemu.  Calling virDomainStop
> immediately after the domain is up is inherently raceful.
> 
> * src/qemu/qemu_driver.c (qemudStartVMDaemon): Add new parameter;
> all callers adjusted.
> (qemudDomainCreate): Implement support for new flag.
> ---
>  src/qemu/qemu_driver.c |   26 +++++++++++++++++---------
>  1 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 11bd2c2..9e5872e 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -154,6 +154,7 @@ static int qemudStartVMDaemon(virConnectPtr conn,
>                                struct qemud_driver *driver,
>                                virDomainObjPtr vm,
>                                const char *migrateFrom,
> +                              bool start_paused,
>                                int stdin_fd,
>                                const char *stdin_path);
...

Looks fine. I don't quite like the migrateFrom and start_paused having similar
meaning wrt to cpus being started or not but I don't see a better way to
implement it.

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]