[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: remove xen reference in header comment v2



On 06/09/2010 03:00 AM, Justin Clift wrote:
> With libvirt and virsh now being used for much more than Xen, this
> patch removes the outdated reference to Xen in the file header.
> 
> ---
> 
> Also changed the commit message to be all lower case, as previously
> mentioned by Eric. ;)

You're picking up quickly ;)

Still, I ended up tweaking your commit message, to drop the v2 from
future 'git log --oneline' output (since I am not pushing v1).  If the
v2 occurs in the leading brackets instead of the tail of the message,
than 'git am' would have automatically dropped it:

[PATCHv2] virsh: remove xen reference in header comment

Not to mention that when browsing my inbox, the v2 at the end of the
subject got truncated in the mail listing, but including it in the [] up
front is easy to spot.

'git send-email --subject-header=PATCHv2' (or format-patch instead of
send-email if you want to save temporary files to your disk)
automatically sets the [PATCHv2] portion of the subject line.

At any rate, this patch is now pushed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]