[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] allow starting qemu in paused state



On Tue, Jun 08, 2010 at 01:53:49PM -0600, Eric Blake wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=589465
> 
> This patch series only works for creation of a transient domain from
> XML, because only virDomainCreateXML() had a flag parameter (the
> virDomainCreate() API is rather lacking, in that respect).  As such,
> the series is minimally invasive, and can hopefully be backported
> easily to places like RHEL6.  If desired, a later patch can add hooks
> (either a new XML element, or a new command comparable to autostart
> that can toggle the state of a hidden field associated with domains)
> so that virDomainCreate() can also be used to start a paused domain,
> but that will be more invasive.

IMHO we really need to make this work for both APIs. The fact
that VDSM only uses virDomainCreateXML is an application specific
use case & not something we should be relying on. Since the
virDomainCreate() API lacks a flags parameter, we need to define
a new API  virDomainCreateFlags() which it adds it. That lets us
get parity of functionality between transient and persistent
guests.

This series looks ok, but I'd like the other API implemented before
we commit this.

Regards,
Daniel
--
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]