[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] remote: protocol implementation for virDomainCreateWithFlags



On Thu, Jun 10, 2010 at 11:16:10AM -0600, Eric Blake wrote:
> Define the wire format for the new virDomainCreateWithFlags
> API, and implement client and server side of marshaling code.
> 
> * daemon/remote.c (remoteDispatchDomainCreateWithFlags): Add
> server side dispatch for virDomainCreateWithFlags.
> * src/remote/remote_driver.c (remoteDomainCreateWithFlags)
> (remote_driver): Client side serialization.
> * src/remote/remote_protocol.x
> (remote_domain_create_with_flags_args)
> (remote_domain_create_with_flags_ret)
> (REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS): Define wire format.
> * daemon/remote_dispatch_args.h: Regenerate.
> * daemon/remote_dispatch_prototypes.h: Likewise.
> * daemon/remote_dispatch_table.h: Likewise.
> * src/remote/remote_protocol.c: Likewise.
> * src/remote/remote_protocol.h: Likewise.
> * src/remote_protocol-structs: Likewise.
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 1ce488c..d1414af 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -3,7 +3,7 @@
>   *   remote_internal driver and libvirtd.  This protocol is
>   *   internal and may change at any time.
>   *
> - * Copyright (C) 2006-2008 Red Hat, Inc.
> + * Copyright (C) 2006-2010 Red Hat, Inc.
>   *
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
> @@ -696,6 +696,15 @@ struct remote_domain_create_args {
>      remote_nonnull_domain dom;
>  };
> 
> +struct remote_domain_create_with_flags_args {
> +    remote_nonnull_domain dom;
> +    int flags;
> +};

This should be 'unsigned flags' to match the API header


Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]