[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] drivers: add virDomainCreateWithFlags if virDomainCreate exists



On Thu, Jun 10, 2010 at 11:16:11AM -0600, Eric Blake wrote:
> * src/esx/esx_driver.c (esxDomainCreate): Move guts...
> (esxDomainCreateWithFlags): ...to new function.
> (esxDriver): Trivially support the new API.
> * src/lxc/lxc_driver.c (lxcDomainStart, lxcDomainStartWithFlags)
> (lxcDriver): Likewise.
> * src/opennebula/one_driver.c (oneDomainStart)
> (oneDomainStartWithFlags, oneDriver): Likewise.
> * src/openvz/openvz_driver.c (openvzDomainCreate)
> (openvzDomainCreateWithFlags, openvzDriver): Likewise.
> * src/qemu/qemu_driver.c (qemudDomainStart)
> (qemudDomainStartWithFlags, qemuDriver): Likewise.
> * src/test/test_driver.c (testDomainCreate)
> (testDomainCreateWithFlags, testDriver): Likewise.
> * src/uml/uml_driver.c (umlDomainStart, umlDomainStartWithFlags)
> (umlDriver): Likewise.
> * src/vbox/vbox_tmpl.c (vboxDomainCreate)
> (vboxDomainCreateWithFlags, Driver): Likewise.
> * src/xen/xen_driver.c (xenUnifiedDomainCreate)
> (xenUnifiedDomainCreateWithFlags, xenUnifiedDriver): Likewise.
> * src/xenapi/xenapi_driver.c (xenapiDomainCreate)
> (xenapiDomainCreateWithFlags, xenapiDriver): Likewise.
> ---
> 
> I found the spots to patch by:
> git grep 'omainCreate \*/'
> 
> but I chose not to touch the few instances of domainCreate functions
> tied to xenUnifiedDriver, instead making xen_driver.c reject
> a non-zero flag before drilling down to the lower-layer create.
> 
>  src/esx/esx_driver.c        |   12 +++++++++---
>  src/lxc/lxc_driver.c        |   22 +++++++++++++++++++---
>  src/opennebula/one_driver.c |   11 +++++++++--
>  src/openvz/openvz_driver.c  |   12 ++++++++++--
>  src/qemu/qemu_driver.c      |   15 +++++++++++++--
>  src/test/test_driver.c      |   10 ++++++++--
>  src/uml/uml_driver.c        |    9 +++++++--
>  src/vbox/vbox_tmpl.c        |   10 ++++++++--
>  src/xen/xen_driver.c        |   12 ++++++++++--
>  src/xenapi/xenapi_driver.c  |   21 ++++++++++++++++++---
>  10 files changed, 111 insertions(+), 23 deletions(-)

ACK

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]