[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/5] libvirt: introduce domainCreateWithFlags API



On Thu, Jun 10, 2010 at 12:21:19PM -0600, Eric Blake wrote:
> Persistent domain creation needs the same features as transient
> domains, but virDomainCreate lacks the flags argument present in
> virDomainCreateXML.  virDomainCreateFlags is already claimed as
> a public enum, so we have to break convention and expose
> virDomainCreateWithFlags.
> 
> * include/libvirt/libvirt.h.in (virDomainCreateWithFlags): Add.
> * src/driver.h (virDrvDomainCreateWithFlags): Internal API.
> * src/libvirt.c (virDomainCreateWithFlags): Glue public API to
> driver API.
> * src/libvirt_public.syms (LIBVIRT_0.8.2): Expose public API.
> * src/esx/esx_driver.c (esxDriver): Add stub for driver.
> * src/lxc/lxc_driver.c (lxcDriver): Likewise.
> * src/opennebula/one_driver.c (oneDriver): Likewise.
> * src/openvz/openvz_driver.c (openvzDriver): Likewise.
> * src/phyp/phyp_driver.c (phypDriver): Likewise.
> * src/qemu/qemu_driver.c (qemuDriver): Likewise.
> * src/remote/remote_driver.c (remote_driver): Likewise.
> * src/test/test_driver.c (testDriver): Likewise.
> * src/uml/uml_driver.c (umlDriver): Likewise.
> * src/vbox/vbox_tmpl.c (Driver): Likewise.
> * src/xen/xen_driver.c (xenUnifiedDriver): Likewise.
> * src/xenapi/xenapi_driver.c (xenapiDriver): Likewise.
> ---
>  include/libvirt/libvirt.h.in |    2 +
>  src/driver.h                 |    6 ++++-
>  src/esx/esx_driver.c         |    1 +
>  src/libvirt.c                |   45 +++++++++++++++++++++++++++++++++++++++++-
>  src/libvirt_public.syms      |    6 +++++
>  src/lxc/lxc_driver.c         |    1 +
>  src/opennebula/one_driver.c  |    1 +
>  src/openvz/openvz_driver.c   |    1 +
>  src/phyp/phyp_driver.c       |    1 +
>  src/qemu/qemu_driver.c       |    1 +
>  src/remote/remote_driver.c   |    1 +
>  src/test/test_driver.c       |    1 +
>  src/uml/uml_driver.c         |    1 +
>  src/vbox/vbox_tmpl.c         |    1 +
>  src/xen/xen_driver.c         |    1 +
>  src/xenapi/xenapi_driver.c   |    1 +
>  16 files changed, 69 insertions(+), 2 deletions(-)

ACK


Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]