[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 1/2] virsh: add pool support to vol-key command



On Fri, Jun 11, 2010 at 09:51:55PM +1000, Justin Clift wrote:
> Presently the vol-key command only supports being provided with
> a volume path.
> 
> This patch adds support for providing it with a pool and volume
> identifier pair as well.
> 
>     virsh # vol-key --pool <pool-name-or-uuid> <vol-name-or-path>
> 
> ---
> This is a clean patch against current git head, plus avoids a
> potential memory leak in the v1 code.  It's identical to the v2
> code, except now I may have the PATCHv3 subject prefix correct. :)
> 
> Also unlike the v1 patch, this one doesn't change the help text for
> other volume commands.
> 
> The patch following this one addresses the help text of the vol-name
> and vol-path commands.
> 
>  tools/virsh.c   |    6 +++---
>  tools/virsh.pod |    7 ++++---
>  2 files changed, 7 insertions(+), 6 deletions(-)

ACK

Daniel
--
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]