[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers



On 06/11/2010 10:45 AM, Matthias Bolte wrote:
> I started this patch like that. I added a minimal driver that does
> exactly that and I edited virInitialize like this:
> 
> # ifdef WITH_ESX
>     if (esxRegister() == -1) return -1;
> # else
>     if (disabledRegister("esx") == -1) return -1;
>     if (disabledRegister("gsx") == -1) return -1;
> # endif
> 
> But I dropped it after I thought that I could not make this work with
> driver modules. But as I think of it now again: I could just have
> called disabledRegister in virDriverLoadModule when the requested
> driver wasn't found. Damn, I should have give it a second thought
> before pushing this patch. :(
> 
> My first approach wouldn't have touched the way do_open picks the
> drivers, so it's not that invasive. It would just have put those
> "disabled" entries in to the driver table.
> 
> Maybe I should recreate that disabled driver, just to see if I can
> make it really working properly.
> 
> Any interest in that approach?

Sure; we can always 'git revert' out one patch to replace it with a
better approach, if we like how it turns out.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]