[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Adding support for IVM



On 06/16/2010 01:22 PM, Eduardo Otubo wrote:
> Fixing all pointed in the previous email.
> Thanks for all the comments.
> 
> @@ -488,11 +498,45 @@ phypExec(LIBSSH2_SESSION * session, char *cmd, int *exit_status,
>      return virBufferContentAndReset(&tex_ret);
>  }
>  
> +static char *
> +hmc_helper(int system_type, const char *managed_system)
> +{
> +    char *unsafe = NULL;
> +    if (system_type == HMC)
> +        virAsprintf(&unsafe, "-m %s", managed_system);
> +    else
> +        unsafe[0] = 0;
> +    return unsafe;

Unfortunately, for the IVM case, this dereferences NULL :(

And it has the problem that it is not thread-safe.

I'm going to try my hand at tweaking this patch to use virBuffer
instead, but we are getting closer...

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]