[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] nwfilter: add XML attribute to control match target



On 06/17/2010 02:23 PM, Eric Blake wrote:
On 06/11/2010 12:02 PM, Stefan Berger wrote:
This patch adds an optional XML attribute to a nwfilter rule to give the
user control over whether the rule is supposed to be using the state
match or not. A rule may now look like shown in the XML below with the
statematch attribute either having value '0' or 'false' (case-insensitive).

[...]
<rule action='accept' direction='in' statematch='false'>
<tcp srcmacaddr='1:2:3:4:5:6'
            srcipaddr='10.1.2.3' srcipmask='32'
            dscp='33'
            srcportstart='20' srcportend='21'
            dstportstart='100' dstportend='1111'/>
</rule>
[...]

I am also extending the nwfilter schema and add this attribute to a test
case.

V2:
  - Following D. Berrange's suggestion I inverted the logic from
'nomatch' XML attribute to statematch attribute

Signed-off-by: Stefan Berger

---
  docs/schemas/nwfilter.rng                 |   10 ++++++++++
Sorry for not noticing sooner, now that you have pushed, but:

Can you also write a patch for docs/formatnwfilter.html.in, to cover
this addition in the documentation?

Yes, I'll write a patch for the documentation also.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]