[libvirt] [PATCHv2 2/2] virsh: add new --details option to vol-list
Eric Blake
eblake at redhat.com
Fri Jun 18 16:34:50 UTC 2010
On 06/18/2010 10:08 AM, Justin Clift wrote:
> On 06/18/2010 06:31 PM, Justin Clift wrote:
> <snip>
>> + // The capacity value to output
>> + val = prettyCapacity(volumeInfo.capacity,&unit);
>> + virBufferVSprintf(&bufStr, "%.2lf %s", val, unit);
>> + volInfoTexts[i]->capacity =
>> + vshStrdup(ctl, virBufferContentAndReset(&bufStr));
>> +
>> + // The allocation value to output
>
> Ugh. Just noticed these two // comments instead of /* */ ones.
>
> Should I fix and resubmit?
If that's the only issue, then probably not worth a resubmission. I'll
see if I spot anything else while reviewing the actual patch, though...
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100618/344ad45e/attachment-0001.sig>
More information about the libvir-list
mailing list