[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/2] virsh: add new --details option to vol-list



On 06/18/2010 10:08 AM, Justin Clift wrote:
> On 06/18/2010 06:31 PM, Justin Clift wrote:
> <snip>
>> +            // The capacity value to output
>> +            val = prettyCapacity(volumeInfo.capacity,&unit);
>> +            virBufferVSprintf(&bufStr, "%.2lf %s", val, unit);
>> +            volInfoTexts[i]->capacity =
>> +                vshStrdup(ctl, virBufferContentAndReset(&bufStr));
>> +
>> +            // The allocation value to output
> 
> Ugh.  Just noticed these two // comments instead of /* */ ones.
> 
> Should I fix and resubmit?

If that's the only issue, then probably not worth a resubmission.  I'll
see if I spot anything else while reviewing the actual patch, though...

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]