[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] esx: Use bool instead of int where appropriated



On 06/18/2010 10:48 AM, Matthias Bolte wrote:
> ---
>  src/esx/esx_util.c |   10 ++--
>  src/esx/esx_util.h |   10 ++--
>  src/esx/esx_vmx.c  |  126 +++++++++++++++++++++++++++------------------------
>  src/esx/esx_vmx.h  |    2 +-
>  4 files changed, 78 insertions(+), 70 deletions(-)

ACK, with one nit.  I couldn't easily verify whether <stdbool.h> had
been included prior to the declarations in esx_util.h and esx_vmx.h; you
should probably add #include <stdbool.h> to both of those headers to
make it obvious that the use of bool is safe.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]