[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] Do not free static buffer with UUID



2010/6/17 Jiri Denemark <jdenemar redhat com>:
> As anywhere else, uuid is defined as a fixed size array inside
> _virSecret structure; we shouldn't try to free it.
> ---
>  src/datatypes.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/datatypes.c b/src/datatypes.c
> index 8750406..36a2b55 100644
> --- a/src/datatypes.c
> +++ b/src/datatypes.c
> @@ -1271,7 +1271,6 @@ virGetSecret(virConnectPtr conn, const unsigned char *uuid,
>  error:
>     if (ret != NULL) {
>         VIR_FREE(ret->usageID);
> -        VIR_FREE(ret->uuid);
>         VIR_FREE(ret);
>     }
>     return NULL;
> --
> 1.7.1
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]