[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] nwfilter: fix loadable module support



On Tue, Jun 22, 2010 at 08:00:14AM -0400, Stefan Berger wrote:
> On 06/22/2010 07:11 AM, Daniel P. Berrange wrote:
> >
> >statstest links to libvirt_test.la which links to libvirt_driver.la
> >so it will inherit the link to gnutls still.
> >
> >We should not need to add any libraries directly to libvirt_la_LIBADD,
> >always to one of the other modules first.
> >
> >   
> >>diff --git a/src/Makefile.am b/src/Makefile.am
> >>index 5109302..eb93727 100644
> >>--- a/src/Makefile.am
> >>+++ b/src/Makefile.am
> >>@@ -1001,10 +1002,10 @@ libvirt_la_LDFLAGS =
> >>$(VERSION_SCRIPT_FLAGS)$(LIBVIRT_SYMBOL_FILE) \
> >>                     $(CYGWIN_EXTRA_LDFLAGS) $(MINGW_EXTRA_LDFLAGS)
> >>  libvirt_la_BUILT_LIBADD += ../gnulib/lib/libgnu.la
> >>  libvirt_la_LIBADD += $(LIBXML_LIBS) \
> >>-                   $(LIBPCAP_LIBS) $(LIBNL_LIBS) \
> >>+                   $(LIBPCAP_LIBS) $(LIBNL_LIBS) $(GNUTLS_LIBS) \
> >>     
> >These two previous additions of LIBPCAP and LIBNL are both wrong
> >too. They should be linking to libvirt_driver_nwfilter.la instead.
> >   
> 
> LIBNL is an addition due to macvtap.c rather than nwfilter.

Ah, ok that one should be against  libvirt_util_la_LIBADD then

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]