[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] esx: Add support for the controller element



2010/6/23 Eric Blake <eblake redhat com>:
> On 06/17/2010 03:15 PM, Matthias Bolte wrote:
>> Also don't abuse the disk driver name to specify the SCSI controller
>> model anymore:
>>
>>   <driver name='buslogic'/>
>>
>> Use the newly added model attribute of the controller element for this:
>>
>>   <controller type='scsi' index='0' model='buslogic'/>
>
> I don't see any change to docs/schemas/domain.rng for this new XML
> attribute.  Am I missing something, or how do you write an xml file that
> uses this attribute and still passes validation?

The model attribute itself was added in a previous patch of this
series, including domain.rng extension. This patch adds usage for the
previously added attribute.

Validation is another problem... Currently the domain XML dumped by
the ESX driver doesn't pass validation anyway, e.g. because the driver
doesn't output the boot order (which is required for HVM in the
domain.rng), because boot order is complicated with ESX and not easy
to determine. But that's a different problem.

>>
>> The disk driver name approach is deprecated now, but still works for
>> backward compatibility reasons.
>>
>> Update the documentation and tests accordingly.
>>
>> Fix usage of the words controller and id in the VMX handling code. Use
>> controller, bus and unit properly.
>> ---
>>  docs/drvesx.html.in                              |   25 +-
>
> Is the xml addition ESX-specific, or should the new controller attribute
> also be documented in docs/formatdomain.html.in?  Is anything other than
> model='lsilogic' supported?

Currently it's only used by ESX, but it should be documented in
docs/formatdomain.html.in. The problem here is that
docs/formatdomain.html.in currently completely lacks documentation for
the controller element, that was initially added for the QEMU driver a
while ago.

So, I'll have to document the controller element first in order to
document the model attribute in a central place. For now I adapted the
existing documentation in the ESX section to document the model
attribute.

Currently the model attribute accepts the 3 already known values
buslogic, lsilogic and lsisas1068. There will be at least 2 additions
soon.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]